77b0954c70
use a macro for the display of boolean settings
5 years ago
af7dbbf1e4
added logic for reverse proxy login
5 years ago
b661c2fa92
added config fields to settings table
5 years ago
e308a74dc2
Fix ( #1103 ) Internal server error with Goodreads and no result for author name on Goodreads
5 years ago
040d7d9ae3
Remove unused import and fix python3 compatibility, as per Ozielsaacs comments.
5 years ago
f9b1e84704
Remove backblaze leftovers
5 years ago
eede894e72
Merge remote-tracking branch 'merge-metadata'
5 years ago
55c0bb6d34
Set the "Size" attribute for Kobo download_urls, and refactor the code
...
to eventually allow formats other than KEPUB.
5 years ago
2b55b9b250
Use the login_user Cookie to authorize download requests instead of
...
passing the UserKey over url params.
5 years ago
22add37b64
Merge remote-tracking branch 'fix typo in config_edit.html #1097'
...
Updated translations
5 years ago
8a9695d48e
Fix getting metadata from douban ( #858 )
5 years ago
e0faad1e59
Handle no write permission to tmp folder ( #1060 )
5 years ago
fffa2d5a1b
Support passing the Auth token as a url param.
...
This is required to support ebook downloads which the Kobo device emits
without any auth headers.
* Also some other small bug fixes discovered during device testing.
5 years ago
0926ae530c
Remove custom_column usages from an earlier commit.
5 years ago
0b709f7dfb
Merge branch 'master' into kobo
5 years ago
b5da2c4199
Clean-up: Fix import order in kobo.py, and other minor formatting
...
changes.
5 years ago
9ede01f130
* Add a UserKeyToken to the User table for Kobo authorization.
...
* Add proper authorization checks on the new Kobo endpoints.
Important Note: As a side-effect, all CalibreWeb API calls can be
authorized using this token (i.e without a username&password).
5 years ago
c61463447f
Merge metadata of uploaded book versions.
5 years ago
55b54de6a0
Add simple get_download_url implementation to replace the backblaze-backed implementation
5 years ago
5357867103
Add initial support for Kobo device Sync endpoint.
...
- Supports /v1/library/sync call to get list of books
- Supports /v1/library/metadata call to get metadata for a given book
+ Assumes books are stored on Backblaze for metadata call
- Changes to helper.py so that we can return no cover instead of a blank
image.
5 years ago
222797e631
support douban book search using apikey
5 years ago
92841b46d7
update Simplified Chinese translations.
5 years ago
4c2323fcc9
fix typo in config_edit.html
5 years ago
fda0ab1e86
FIx for ( #1092 listening to mp3 not working)
5 years ago
54079b36ae
Fix #1095 (epub viewer not working if only viewer rule wa sapplied)
5 years ago
f8a99c60d8
Fix for #1096 (exception on digest request)
5 years ago
8af178c19c
Fix for gdrive not working #1081
5 years ago
78f9ee86b1
Fix pdf cover
...
Fix massadding books
Add feature inform of duplicate books
5 years ago
ab5873984e
Merge remote-tracking branch 'translation/patch-3'
5 years ago
62ea8b8913
Logging to stdout, proposal form #1078
5 years ago
a4416c202d
Merge remote-tracking branch 'rename/develop'
5 years ago
1f5edffccf
Fix typo and update translation
5 years ago
651260022c
Merge remote-tracking branch 'search_title/hotfix-searchform-title'
5 years ago
2e4344f7ea
Merge remote-tracking branch 'swedish/master'
5 years ago
3cb7e77b60
Update messages.po
5 years ago
f782dc1857
fix for search title
5 years ago
88f31ddad1
Fix for #1034
5 years ago
a7ab7fcf06
Fix #1068 PDF cover Images inverted or incorrect single image grabbed from cover page
5 years ago
6f61e80c97
Fix #1074 , #1071
5 years ago
d1afdb4aac
Fix #1074 , #1071
5 years ago
5167ee520e
Solve cropped image pdf import ( #1068 )
5 years ago
f758a1cc64
Solve inverted image pdf import ( #1068 )
5 years ago
2145be6db2
Improvement for #1062
5 years ago
c740fe9124
Merge remote-tracking branch 'github_2/it-adds-info-to-shelf-order'
5 years ago
a371e40c66
Merge remote-tracking branch 'github_3/hotfix/epub-import'
...
Improved cover extraction from epub files
5 years ago
ccc6184342
Merge remote-tracking branch 'github_1/patch-1'
5 years ago
c8c2d6659c
Merge remote-tracking branch 'public_reconnect/master'
5 years ago
c7d7a7597c
remove language from array metadata
5 years ago
fbb7663a2f
epub metadata import fix
5 years ago
c93dd32179
Fixed typo and column size for LG screens
5 years ago
7165826011
Adds Authors, Series and Book Cover to the shelf order view
5 years ago
ada727a570
Adds Authors, Series and Book Cover to the shelf order view
5 years ago
01b0f9534c
fix issue #1064
...
Allow for finer steps in serie-index
5 years ago
3764c33a3a
Add the posibility to change the username
5 years ago
9fc02f67c2
Debug output for lcase
5 years ago
0c40e40dc3
Fix logfile loading behind reverse proxy ( #1047 )
5 years ago
e31df16309
Revert bug in updater.py preventing new files from being created
5 years ago
d7ea5bb9d7
Fix for #1037
...
Update German translation
5 years ago
6cda5fee0d
Fix language selection on python3
5 years ago
ca5e285c5a
Merge branch 'Develop'
5 years ago
fb0eebfc52
Merge remote-tracking branch 'spanish/master'
5 years ago
dd90fb003e
Merge remote-tracking branch 'french/master'
5 years ago
61cd044255
Merge remote-tracking branch 'polish/master'
5 years ago
879d02081a
Fix #1021
5 years ago
051bc53aa2
Fix for #1009
5 years ago
5515772903
updated spanish translations
5 years ago
ff900fd9c0
updated spanish translations
5 years ago
eec4be7a29
Update cps/translations/fr/LC_MESSAGES/messages.po
...
Co-Authored-By: Johan Bonneau <lhaagounet@gmail.com>
5 years ago
1385ecb383
Update cps/translations/fr/LC_MESSAGES/messages.po
...
Co-Authored-By: Johan Bonneau <lhaagounet@gmail.com>
5 years ago
74418f3139
Update cps/translations/fr/LC_MESSAGES/messages.po
...
Co-Authored-By: Johan Bonneau <lhaagounet@gmail.com>
5 years ago
72def4b97b
Update cps/translations/fr/LC_MESSAGES/messages.po
...
Co-Authored-By: Johan Bonneau <lhaagounet@gmail.com>
5 years ago
564c3b4778
Update cps/translations/fr/LC_MESSAGES/messages.po
...
Co-Authored-By: Johan Bonneau <lhaagounet@gmail.com>
5 years ago
c9eff4a70c
Update cps/translations/fr/LC_MESSAGES/messages.po
...
Co-Authored-By: Johan Bonneau <lhaagounet@gmail.com>
5 years ago
879f63d1c1
Update cps/translations/fr/LC_MESSAGES/messages.po
...
Co-Authored-By: Johan Bonneau <lhaagounet@gmail.com>
5 years ago
3fb458dd19
Update cps/translations/fr/LC_MESSAGES/messages.po
...
Co-Authored-By: Johan Bonneau <lhaagounet@gmail.com>
5 years ago
d9a73b4fa3
French translation
...
Add and modify some little things
5 years ago
23b3bfd967
Additional fix #1016
5 years ago
f543d7f486
Fix #1016
5 years ago
6a058d2c52
Update polish translation
5 years ago
ff41775dbb
Merge remote-tracking branch 'pwr/unpickle-iso-languages' into Develop
5 years ago
d04a78afe6
Merge remote-tracking branch 'public_shelf/Develop' into Develop
5 years ago
f566237be0
Merge remote-tracking branch 'bootstrap/Develop' into Develop
5 years ago
a65ad9483c
update Bootstrap v3.4.0 -> 3.4.1
5 years ago
4cbdccd39e
Fix for https://github.com/janeczku/calibre-web/issues/1002
5 years ago
9356148e2d
Added more information about dependencies
5 years ago
4be55285d8
Fix #1001
5 years ago
3eae2e9c2c
Changed text for not found imports
5 years ago
e9fb5d9f25
Bugfix for comicapi
5 years ago
6261981656
Fix for #991
...
Removed additional psace before Advanced search (Pull request #996 )
Set startup message for not relevant imports to debug, to reduce confusion
5 years ago
82ca3f31f9
Merge remote-tracking branch 'pwr/master'
5 years ago
97f3aa8325
Update dutch language
5 years ago
7c503b4a31
provide a default logging configuration ( fixes #987 )
5 years ago
9f8cab99e3
Moved language names from iso639.pickle to a python file
5 years ago
5f25b81004
Final fix for #983
5 years ago
73bbffccaa
Fix for login issue on MacOS
5 years ago
f59d9d5aa8
Merge remote-tracking branch 'polish/master'
5 years ago
746b7b1262
Update polish translation
5 years ago
5f228fbb40
Update german translation
5 years ago
12576393cf
Merge remote-tracking branch 'spanish/patch-1'
...
Merge remote-tracking branch 'german/master'
5 years ago
7f43a2e104
Update messages.po
...
update and revision of the Spanish translation file.
5 years ago
00f17bb697
Mature contents no longer displayed in/allowed to ( #975 ):
...
- typeahead tags
- advanced search tags buttons
- read
- download
5 years ago
cf00b4eebf
Cover upload gives Error 500 fix #972 (leftover from refactoring)
...
OPDS cannot be downloaded Fix #973 (wrong blueprint selected with wrong authentication type)
Read books with link to calibre wern't detected correct Fix #971 (Refactoring error "is" is not equal to "==" for sqlalchemy)
5 years ago
fc4dc36c65
Fix #969 (duplicate code "init" in epub reader)
...
Fix for #890
6 years ago
97a0dccdec
Fix for display of format, series, category, ratings,
...
Fix for display of language (sorting not working yet)
6 years ago
9f64a96502
Fix for #890
6 years ago
b9c3a3fcea
Fix #652
6 years ago
6d43e0422a
Fix for non found flask_login version ( #968 )
6 years ago
0d7e58ce79
Fix for #968 (database conversion fails for default strings under python2.7)
6 years ago
3e008ef29b
Fix update dates shown in local time format again
...
Fix "to update" history is shown again
6 years ago
5c6be5d6d0
Fix for python 3 and existing unrar entry in db
...
deleted unnecessary lines in config html template
6 years ago
38f3c2d5b9
Reenabled multiple oauth provider
...
deleted duplicate download counting function
6 years ago
c6542fdec6
New Oauth code
6 years ago
26a7d9ef30
Merge branch 'Develop'
...
# Conflicts:
# cps/__init__.py
# cps/about.py
# cps/admin.py
# cps/cli.py
# cps/config_sql.py
# cps/constants.py
# cps/converter.py
# cps/db.py
# cps/editbooks.py
# cps/gdriveutils.py
# cps/helper.py
# cps/logger.py
# cps/oauth.py
# cps/server.py
# cps/services/simpleldap.py
# cps/ub.py
# cps/web.py
# cps/worker.py
# optional-requirements.txt
# setup.cfg
# setup.py
6 years ago
d168e3bfdb
Add licence to oauth
...
fix comicapi dependency
6 years ago
99c6247baf
use the standard socket library to validate the ip address argument
6 years ago
a334ef28e7
about page: build the versions dictionary only once
6 years ago
63634961d4
cleaner worker api
...
the worker thread now stops on its own
6 years ago
d82289e303
Deactivate ldap
...
Fix setup for pypi
6 years ago
a836df9a5a
more robust disposing of database session
...
avoid spamming the log with debug messages from libraries
6 years ago
8bfcdffeb6
Fix feature support
6 years ago
e411c0fded
Fix logging in debug mode
6 years ago
4708347c16
Merge branch 'Develop'
...
# Conflicts:
# MANIFEST.in
# README.md
# cps/helper.py
# cps/static/js/archive/archive.js
# cps/translations/nl/LC_MESSAGES/messages.mo
# cps/translations/nl/LC_MESSAGES/messages.po
# cps/ub.py
# cps/updater.py
# cps/web.py
# cps/worker.py
# optional-requirements.txt
6 years ago
792367e35e
Version update
6 years ago
be64961de5
Code cosmetics comic reader
6 years ago
405a3909b0
Fix for opds with LDAP authentication
6 years ago
b1cb7123a3
Fix for #959
6 years ago
e734bb120a
Merge remote-tracking branch 'github/config_sql' into Develop
6 years ago
006e596c72
Moved config class into separate file.
...
Moved Goodreads and LDAP services into separate package.
6 years ago
499a66dfb0
Additional glyphicons for music on search and author page
...
Fix duplicate user and email (now case insensitive)
Output of calibre on stderr is now logged (full traceback in debug-log, otherwise, only errormessage)
Natural sorting for comic reader
Fix for long running tasks
6 years ago
f79d549910
Fix duplicate user and email (now case insensitive #948 )
...
Fix sorting in comics (#950 )
Fix log error on Calibre converter error (#953 )
Fix long running tasks (#954 )
6 years ago
ad44e58c7a
Sorting for comics
...
Audiobook support
6 years ago
572b5427c7
Fix Encoding issues for python2
6 years ago
32af660f86
Improvements for logfile viewer
...
Fix for tornado-server with deactivated accesslog doesn't log to normal log anymore
Merge from master for unique user ids, get_metadata,
fix Goodreads integration
Update Translation (merge NL, update DE)
6 years ago
cc8a431532
Merge remote-tracking branch 'socket/unix-socket' into Develop
6 years ago
5c7aeb2f2c
Change GDrive
6 years ago
e254565901
support binding the http server to a unix socket file instead of TCP socket
6 years ago
d9f69ca264
Updated Dutch translation
6 years ago
cd546eb6d4
Update comic reader js
6 years ago
f40fc5aa75
Update LDAP
6 years ago
9b74d51f21
Merge remote-tracking branch 'ldap/master' into Develop
...
# Conflicts:
# cps/server.py
# cps/templates/config_edit.html
# cps/ub.py
# cps/updater.py
# cps/web.py
# optional-requirements-ldap.txt
# setup.cfg
6 years ago
d45b1b8ea5
Fix #937
...
logviewerintegrated
Code cosmetics
6 years ago
e67d707867
Fix for #588
...
Merge remote-tracking branch 'linuxserver/master'
6 years ago
4437d7376d
Merge pull request #2 from Krakinou/flaskldap
...
Solve typo
6 years ago
304db0d20e
Solve typo
6 years ago
3f5c6c1fa5
Fix #937
6 years ago
26949970d8
Revert logging functions
...
Fix access logger for tornado
6 years ago
f5e3ed26b9
Fix for #935
6 years ago
8e4539cf8e
Prevent delete of last admin user
6 years ago
c81d4edb7d
Fix for #923
6 years ago
546ed65e1d
Update logging
...
Fix sort order author
Fixes sorting view
Moved version info
added feature limit listening to single ipaddress
6 years ago
14b6202eec
Code cosmetics
...
Fixes func in helper,web
Fixes for pdf reader
fixes for calling from another folder
renamed to calibreweb for importing in python caller script
6 years ago
50973ffb72
Merge remote-tracking branch 'constants/Develop-logging-cleanup' into Develop
6 years ago
9a5ab97d78
Merge branch 'master' into master
6 years ago
79286c9384
encode password
6 years ago
c4e3f3670f
Added public /reconnect endpoint
6 years ago
b89ab9ff10
logging clean-up
...
- moved most constants to separate file
- sorted and cleaned-up imports
- moved logging setup to separate file
6 years ago
97d12b94f6
Correct settings update
6 years ago
e4d801bbaf
initial flask_simpleldap implementation
6 years ago
f736a15c12
Fix for restart of newer versions of tornado during update
...
Fix for updater with Beta Versions
6 years ago
a02f949d23
Fix for updater with beta releases
6 years ago
bb0d5c5538
Working for pip and "normal" start for python3 and python2
6 years ago
87ca05f129
Merge remote-tracking branch 'setup/feature/setuptools-integration'
6 years ago
6662a58cb0
Update translationfiles
6 years ago
4fecce0a0d
Merge branch 'master' into Develop
...
# Conflicts:
# cps/helper.py
# cps/static/js/archive/unrar.js
# cps/templates/readcbr.html
# cps/templates/readpdf.html
# cps/translations/de/LC_MESSAGES/messages.mo
# cps/translations/de/LC_MESSAGES/messages.po
# cps/translations/es/LC_MESSAGES/messages.mo
# cps/translations/es/LC_MESSAGES/messages.po
# cps/translations/fr/LC_MESSAGES/messages.mo
# cps/translations/fr/LC_MESSAGES/messages.po
# cps/translations/it/LC_MESSAGES/messages.mo
# cps/translations/it/LC_MESSAGES/messages.po
# cps/translations/ja/LC_MESSAGES/messages.mo
# cps/translations/ja/LC_MESSAGES/messages.po
# cps/translations/km/LC_MESSAGES/messages.mo
# cps/translations/km/LC_MESSAGES/messages.po
# cps/translations/nl/LC_MESSAGES/messages.mo
# cps/translations/nl/LC_MESSAGES/messages.po
# cps/translations/pl/LC_MESSAGES/messages.mo
# cps/translations/pl/LC_MESSAGES/messages.po
# cps/translations/ru/LC_MESSAGES/messages.mo
# cps/translations/ru/LC_MESSAGES/messages.po
# cps/translations/sv/LC_MESSAGES/messages.mo
# cps/translations/sv/LC_MESSAGES/messages.po
# cps/translations/uk/LC_MESSAGES/messages.mo
# cps/translations/zh_Hans_CN/LC_MESSAGES/messages.mo
# cps/translations/zh_Hans_CN/LC_MESSAGES/messages.po
# cps/web.py
# messages.pot
# optional-requirements.txt
6 years ago
26e45f1f57
Merge remote-tracking branch 'comic-reader/master'
6 years ago
df5d15d1a2
Merge remote-tracking branch 'comicapi/master'
6 years ago
ecedf92783
Update version
...
Make custom columns visible (#904 )
6 years ago
d106ada9ed
Changed version
...
Update translation
6 years ago
ed91048a63
Fix for magic link with python 3
6 years ago
f70c839014
Added additional permission viewer
6 years ago
e6ff2f1d90
Fix file not found loading-icon.gif
6 years ago
867aa2f0bd
Beautify bitjs
6 years ago
7982ed877c
Downgrade bitjs to es5 branch
6 years ago
0c80f5c63a
Update Teststatus
6 years ago
1030e195a5
Fix #916
6 years ago
c0d136ccd8
Fix slow loading
6 years ago
479b4b7d82
Update translations, integrated update of Italian translation
6 years ago
a42ebdc096
Fix for #897
6 years ago
49ba221e85
Merge remote-tracking branch 'direction'
6 years ago
3b03aa30a6
Fix for advanced search
6 years ago
cb0403a924
Merge remote-tracking branch 'adv_search/master'
6 years ago
a2c7741e21
Fix "Internal Server Error" on advanced search
...
Custom boolean columns return that error if calibre does not have a
custom_column_1 in the DB, as this is queried in the removed line.
However the value is completely unused anyway -> removing.
6 years ago
55bb8d4590
Fix #900
6 years ago
b80bfa5260
Improvement for #897
6 years ago
f941908f73
Workaround for #889
6 years ago
9b3b2acb49
Sort button is correctly visible on list pages
...
Publisher list is working
6 years ago
406d1c76c9
Sorting and filtering of lists working (except file formats)
...
Refactored and bugfixing show_cover
Refactored import of helper in web.py
Fix for displaying /me (gettext) throwing error 500
Fix get search results throwing error 500
Fix routing books_list for python2.7
Fix for "me" and "settings" pages
Update sidebarview and list view
6 years ago
c2bfb29726
Add reading direction settings to readcbr page
6 years ago
204de4aef6
Fix an issue that fullscreen doens't work on some browsers
6 years ago
8b6d165d64
Fix Japanese translation
6 years ago
bfd0e87a17
Merge branch 'master' into Develop
...
# Conflicts:
# cps/helper.py
# cps/reverseproxy.py
6 years ago
6a7b8c7870
Update Version info
...
Fix #816
Clarified licences for isolanguages.py and reverseproxy.py
6 years ago
2de4bfdcf2
Merge branch 'master' into Develop
...
# Conflicts:
# cps/book_formats.py
# cps/helper.py
# cps/web.py
6 years ago
f1a65a2aeb
Clarified licences for isolanguages.py and reverseproxy.py
6 years ago
cc5c2c0f65
Update Version info
6 years ago
c748716ad2
Fix for opds feed of unread/read books
6 years ago
544405f5aa
Update search for cyrillic letters #877
6 years ago
67736fe187
Catch errors on loading pickle file
...
Fix for cover images without Pillow
6 years ago
89516fc2d6
Make PIL optional #885
6 years ago
e1e79a73e8
Fix #884
6 years ago
0b8624b542
Deleted load metadata from douban, as API seems to be shut down ( #858 )
6 years ago
91ebe33879
Merge remote-tracking branch 'image_formats/dev'
6 years ago
05da2ae3c7
Update search for cyrillic letters
6 years ago
4ae9d4a749
Merge branch 'master' into Develop
...
# Conflicts:
# cps/web.py
# cps/worker.py
6 years ago
55bdd13fb1
Fix #877
6 years ago
4552208c02
Fix #848
6 years ago
436c2671d1
Fix delete domain entries
...
Fix error handling smtp.authentication error
6 years ago
a669eacde9
Merge remote-tracking branch 'proxy/patch-1'
6 years ago
2253708da7
Merge remote-tracking branch 'proxy/patch-1' into Develop
6 years ago
51e591bd25
Added updated translation
6 years ago
5188c62bea
Merge remote-tracking branch 'translation/loc-hu'
6 years ago
2a5f2ff7b3
Merge branch 'master' into Develop
...
# Conflicts:
# cps/templates/readpdf.html
# cps/translations/uk/LC_MESSAGES/messages.po
# cps/web.py
6 years ago
e754ce313c
Merge remote-tracking branch 'pycountry/pycountry'
6 years ago
dc933f3d66
Merge remote-tracking branch 'pdf.js/epubjs'
...
Updated pdf.js
6 years ago
afc79416b2
HU Translation updates
...
Translation of the new untranslated strings
6 years ago
cdfb6bf3e3
Use HTTP_X_FORWARDED_HOST instead of HTTP_X_FORWARDED_SERVER
...
Use HTTP_X_FORWARDED_HOST since HTTP_X_FORWARDED_SERVER holds the hostname of the proxy server on HAProxy/Traefik.
6 years ago
cbdc9876b2
comicapi dependency now pippable
6 years ago
05d0f12608
redid comic importing support to handle metadata properly using comicapi from comictagger. needs work to automate installation
6 years ago
858c80bb20
'except' style fix
6 years ago
f7e640fd98
support pycountry if iso-639 is not available
6 years ago
439ce19b5d
Updated epub.js to v0.3.66
6 years ago
1c9ff6421d
Fix uploader
6 years ago
4b301a7961
Additional fix for #845 (in case of error)
6 years ago
dc93222579
Update 2 column author list view
6 years ago
6c493df2f5
support issue: #843
6 years ago
772f978b45
Improved code quality
6 years ago
0f1db18eae
Simplified typeahead
6 years ago
6940bb9b88
Code improvement
6 years ago
07649d04a3
Fix updater
...
Update translations
Code cleaning updater
6 years ago
39a3f70084
Fix for slow updater
6 years ago
8923e71220
Remove debug logging
6 years ago
843a93fe28
Updater fix for slow servers
6 years ago
fa36072699
Fix uk translation-file
6 years ago
8ab9365688
Prevent error 500 for cover of not exisiting book
6 years ago
169ace777a
Fixed infinite scroll for read and unread displays ( #855 )
6 years ago
ec2103a3d0
fixed a bug that affects allowing password change for users ( #854 )
6 years ago
8e8486497f
Restirct a user to a set of tags
6 years ago
e5593d9a7f
Integrated author in sorting functions
6 years ago
3f2a9c8bae
Code improvement
6 years ago
7c69589c5b
Code cosmetics unrar.js
6 years ago
149e9b4bd4
Code cosmetis unrar
6 years ago
a360b1759a
Code cosmetics
...
bugfix import HttpError from pydrive
6 years ago
765b817384
Refactored shelf.py and editbooks.py
6 years ago
baf83b2f5a
Refactored generating download links
6 years ago
9c1b3f136f
Improved sorting for rated,random, hot books, read/unread book
6 years ago
a66873a9e2
Added file formats view
6 years ago
a0a15b4598
Fix max authors shown
6 years ago
4a33278596
Update ratings
6 years ago
6d2270d931
Fixes for Oauth
6 years ago
1db1c2e7df
Enabling LDAP working again
...
LDAP/Github oauth and Google oauth no credentials/parameters are rejected now
6 years ago
Andrew Roberts