From 11fe0bf03bebc765a68579815ec53879559209d8 Mon Sep 17 00:00:00 2001
From: Castro0o <andre@andrecastro>
Date: Fri, 17 Apr 2020 09:17:11 +0200
Subject: [PATCH] Overview main page: image as links (wip)

---
 dumpwiki.py        | 21 ++++++++++++---------
 static/archive.css |  2 ++
 static/index.css   |  2 ++
 3 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/dumpwiki.py b/dumpwiki.py
index 3638ba4..3f07913 100644
--- a/dumpwiki.py
+++ b/dumpwiki.py
@@ -67,7 +67,7 @@ def filenameforlink(href):
     return href
 
 
-def rewriteimglinks(tree):
+def rewriteimglinks(tree, page):
     #on Overview_main_page
     # add link to publication on <a><img>
 
@@ -76,15 +76,18 @@ def rewriteimglinks(tree):
     for a in tree.findall(".//a[@class='image']"):  # select img wrapping a
         href = a.attrib.get('href')
         if a.findall(".//img"):  # ensure a has child: img
-            img = a.find(".//img")
-            img_src = img.attrib['src']
-            a.attrib['href'] = img_src  # 'javascript:void(0);'  # disable href
-            a.attrib['target'] = "_blank"
+            if page.name == 'Overview main page':
+                img = a.find(".//img")
+                img_src = img.attrib['src']
+                a.attrib['href'] = img_src
+            else:
+                a.attrib['href'] = 'javascript:void(0);'  # disable href
+
             print(a)
             print(ET.tostring(a, method="html", encoding="unicode"))
     return tree
 
-def rewritelinks (html):
+def rewritelinks(html):
     t = html5lib.parseFragment(html, treebuilder = "etree", namespaceHTMLElements = False)
     for a in t.findall(".//*[@href]"):
         linkclass = a.attrib.get("class", "")
@@ -100,7 +103,7 @@ def rewritelinks (html):
     return html
 
 
-def rewriteimgs(html):
+def rewriteimgs(html, page):
     t = html5lib.parseFragment(html, treebuilder = "etree", namespaceHTMLElements = False)
 
     # replace images url with local image in ../images
@@ -131,7 +134,7 @@ def rewriteimgs(html):
         img.attrib['width'] = ""
         img.attrib['height'] = ""
 
-    t = rewriteimglinks(tree=t)
+    t = rewriteimglinks(tree=t, page=page)
 
     html = ET.tostring(t, method="html", encoding="unicode")
     return html
@@ -140,7 +143,7 @@ def dumppage(p, template, rewrite_images=True):
     htmlsrc = site.parse(page=p.name)['text']['*']
     htmlsrc = rewritelinks(htmlsrc)
     if rewrite_images:
-        htmlsrc = rewriteimgs(htmlsrc)
+        htmlsrc = rewriteimgs(html=htmlsrc, page=p)
     html = template.render(page=p, body=htmlsrc, staticpath='.')
     with open(os.path.join(args.output, filenameforpage(p)), 'w') as f:
         f.write(html)
diff --git a/static/archive.css b/static/archive.css
index f2db950..0c99a6b 100644
--- a/static/archive.css
+++ b/static/archive.css
@@ -65,3 +65,5 @@ a:hover {
 	text-decoration: none;
   	color: blue;
 }
+
+a.image {cursor: default!important;} /* KEEP THIS: it is important to avoid images to seeming like links */
\ No newline at end of file
diff --git a/static/index.css b/static/index.css
index 3cea8a2..68d8aec 100644
--- a/static/index.css
+++ b/static/index.css
@@ -293,3 +293,5 @@ margin-left: 40px;
   height: 2px;
   background-color: #0BEFEB;
 }
+
+a.image {cursor: pointer!important;} /* KEEP THIS: show imgs as link in Overview */
\ No newline at end of file